Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(bundles): refactor @nextcloud/vue imports to use the esm bundle #5412

Merged
merged 1 commit into from
Aug 16, 2023
Merged

perf(bundles): refactor @nextcloud/vue imports to use the esm bundle #5412

merged 1 commit into from
Aug 16, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 14, 2023

Bundle sizes (npm run build):
Before: 8,5M js/calendar-main.js
After: 5,6M js/calendar-main.js

@st3iny st3iny added 3. to review Waiting for reviews performance 🚀 labels Aug 14, 2023
@st3iny st3iny self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (7f39c7b) 22.66% compared to head (baeeae2) 22.65%.
Report is 18 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5412      +/-   ##
============================================
- Coverage     22.66%   22.65%   -0.01%     
- Complexity      372      387      +15     
============================================
  Files           237      240       +3     
  Lines         11725    11825     +100     
  Branches       2282     2302      +20     
============================================
+ Hits           2657     2679      +22     
- Misses         9068     9146      +78
Flag Coverage Δ
javascript 13.82% <0.00%> (-0.07%) ⬇️
php 64.88% <ø> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...NavigationHeader/AppNavigationHeaderDatePicker.vue 0.00% <ø> (ø)
...ppNavigationHeader/AppNavigationHeaderNewEvent.vue 0.00% <ø> (ø)
...avigationHeader/AppNavigationHeaderTodayButton.vue 0.00% <ø> (ø)
...ppNavigationHeader/AppNavigationHeaderViewMenu.vue 0.00% <ø> (ø)
...components/AppNavigation/AppointmentConfigList.vue 0.00% <0.00%> (ø)
...ppointmentConfigList/AppointmentConfigListItem.vue 0.00% <0.00%> (ø)
...ts/AppNavigation/CalendarList/CalendarListItem.vue 0.00% <0.00%> (ø)
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø)
...Navigation/CalendarList/PublicCalendarListItem.vue 0.00% <0.00%> (ø)
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)
... and 61 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny force-pushed the perf/bundles/nc-vue-esm branch 2 times, most recently from c2904b9 to 7793a80 Compare August 14, 2023 15:48
@st3iny
perf(bundles): refactor @nextcloud/vue imports to use the esm bundle
baeeae2 
Bundle sizes (npm run build):
Before: 8,5M js/calendar-main.js
After:  5,6M js/calendar-main.js

Signed-off-by: Richard Steinmetz <[email protected]>
tcitworld
tcitworld approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:feels_good:

ChristophWurst
ChristophWurst approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnificent

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 16, 2023
@st3iny st3iny merged commit c8d43e4 into main Aug 16, 2023
38 of 40 checks passed
@st3iny st3iny deleted the perf/bundles/nc-vue-esm branch August 16, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

Assignees

@st3iny st3iny

Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st3iny @ChristophWurst @tcitworld